I remember there an easter egg on eg that rock paper sicissors.

Quote from: dark_void on January 28, 2012, 03:52:08 AM

I remember there an easter egg on eg that rock paper sicissors.

8th i think

No, its the 1st. I just did it today

Okay I see a couple errors at the moment. Including your inputError one.

I'll start with the error you asked first. At the end of you Elseif block you have this piece of code
elif player_choice != rock or paper or scissors:
    inputerror()

This is incorrect, Since this statment will ALWAYS evaluate to TRUE. This is because the statement you have above is the same as this one.
elif player_choice != rock or 2 or 3: #remember you defined paper = 2 and scissors = 3:
    inputerror()

And this Code is also the same as because any value besides 0 is considered True.
elif player_choice != rock or True or True:
   inputerror()


What you probably meant to write was this:
elif player_choice != rock or player_choice != paper or player_choice != scissors:
   inputerror()

Which sadly is also incorrect. Since you want to use the AND operator because you want to make sure the user inputed none of the options. That will fix this error. Now the next problem arises since you defined rock paper and scissors to be numerical values and the user is inputting a string. 

So if player_choice == scissors and computer_choice == 1: doesn't really make sense since player_choice should be "rock" "paper" or "scissors" and the value of scissors is 2.


I'll let you work on it some more since I don't wanna fix the whole thing for you.

So, i fix'd some things and the current code is this:

import random, time

print "Loading..."
#3>2>1>3
compwins = 0
playerwins = 0
draw = "Draw! Try again."
print "Defining functions..."
time.sleep(1) #gotta have decoration, y'know?
def inputerror():
    print ""
    print "Error: invalid input. Terminating..."
    time.sleep(4)
    exit()
def situation():
    print 'Your wins: ' #gives concat error when I try to print in one line
    print playerwins
    print 'Comp\'s wins: '
    print compwins


print '''

This is a simple rock-paper-scissors-game.
Type in the numerical equivalent of your choice.
rock = 1 ,paper = 2, scissors = 3
You can see the current situation by typing 'situation()'

Have fun!

'''
player_choice = raw_input("Enter your choice here: ")
str(player_choice)
computer_choice = random.choice('123')


if player_choice == '3' and computer_choice == '1':
    print "rock, you lose!"
    compwins + 1
elif player_choice == '3' and computer_choice == '2':
    print "paper, you win!"
    playerwins + 1
elif player_choice == computer_choice:
    print draw
elif player_choice == '2' and computer_choice == '1':
    print "rock, you win!"
    playerwins + 1
elif player_choice == '2' and computer_choice == '3':
    print "scissors,you lose!"
    compwins + 1
elif player_choice == computer_choice:
    print draw
elif player_choice == '1' and computer_choice == '2':
    print "paper, you lose!"
    compwins + 1
elif player_choice == '1' and computer_choice != 1 and computer_choice != 2: #Doesn't seem to work any other way
    print "scissors, you win!"
    playerwins + 1
elif player_choice == computer_choice:
    print draw
elif player_choice != '1' and player_choice != '2' and player_choice != '3' and player_choice != 'situation':
    inputerror()
elif player_choice == 'situation':
    situation()


It works fine, but the situation() function is pretty much obsolete because it has to restart in the start of every match. Maybe wrapping it up in a function would work? There are some stuff I couldn't figure out as shown in comments. I'm planning on adding some additional decoration in the program. (Gonna make million bucks with this). Opinion?